Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade reveal.js from 3.9.2 to 4.0.0 #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade reveal.js from 3.9.2 to 4.0.0 #19

wants to merge 2 commits into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
medium severity Insecure Randomness
SNYK-JS-REVEALJS-173730		 Yes No Known Exploit
Commit messages
Package name: reveal.js The new version differs by 250 commits.
  • f0b67ad 4.0.0
  • 38eda3a fix livereload
  • df61f9e progress bar width set via scale instead of width for perf
  • 5e49cbd link fix
  • 8b3f57b Merge pull request #2666 from RealCyGuy/patch-1
  • 07db418 fixed links
  • a1f03cb Reveal.VERSION is now available prior to initialization #2651
  • feb43ff rollup cache saves 1s per js build
  • 84b5298 update dependencies
  • 4f22933 reveal.netlify.app -> revealjs.com
  • 83151f5 Merge pull request #2651 from hakimel/dev
  • 5e50136 move fonts from lib/fonts to dist/theme/fonts
  • 0a58c68 move highlight themes from lib/css/ to plugin/highlight/
  • 9d11927 auto-animate example in demo
  • 815557c update all links to docs (will sub out '.netlify.app' once we ship 4.0)
  • f618de8 restore support for markdown speaker notes
  • 13f7e69 distribute /plugin
  • 3d2371f bundle html inside of notes.js, no more need for relatively locating external html
  • 8fc2ec9 removed phantomjs-based print-pdf plugin
  • fb22716 move built plugin files from /dist/plugin/ to /plugin/<name>/
  • 4e89595 readme tweaks
  • c0c6b0a new copy for readme, clearer get started cta
  • 1fb1e9b bigger logo
  • faa4e38 new logo update readme 🥳

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:

🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

@OleVik OleVik self-requested a review May 29, 2020 09:17
@OleVik OleVik added dependencies Pull requests that update a dependency file work in progress labels May 29, 2020
@OleVik OleVik self-assigned this May 29, 2020
@drzraf
Copy link

drzraf commented Apr 22, 2021

Out of curiosity, is there anything else that would make this plugin restricted to reveal.js 3.x (like an hardcoded list of supported option or similar?)

@OleVik
Copy link
Owner

OleVik commented Apr 22, 2021

Not in particular, I just haven't tested it against v4. And seeing as it's a major-version bump, I assume the API will be incompatible. This plugin passes options transparently, so if the API of v3 and v4 are the same, it should work out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OleVik OleVik Awaiting requested review from OleVik

Assignees

@OleVik OleVik

Labels
dependencies Pull requests that update a dependency file work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snyk-bot @drzraf @OleVik